Fix function name shadowing #3022
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
adamreichold
reviewed
Mar 7, 2023
davidhewitt
reviewed
Mar 7, 2023
pyo3-macros-backend/src/pymethod.rs
Outdated
| let associated_method = quote! { | ||
| unsafe fn #wrapper_ident( | ||
| #py: _pyo3::Python<'_>, | ||
| _raw_slf: *mut _pyo3::ffi::PyObject, | ||
| #(#arg_idents: #arg_types),* | ||
| ) -> _pyo3::PyResult<#ret_ty> { | ||
| let function = #cls::#name; |
There was a problem hiding this comment.
Does this imply that fn function is now broken as a #[pymethod] instead? Maybe we need let _pyo3_function instead ?
There was a problem hiding this comment.
Agreed. I also recommend adding a comment describing why we are doing this.
There was a problem hiding this comment.
Does this imply that fn function is now broken as a #[pymethod] instead?
No, why would it? That works fine.
Agreed. I also recommend adding a comment describing why we are doing this.
Sure
There was a problem hiding this comment.
Right I see, because the previous function binding would be correctly rebound by the let. Ignore me!
davidhewitt
approved these changes
Mar 9, 2023
|
@mejrs I've squashed and added a newsfragment. Hope that's ok. bors r+ |
|
Build succeeded: |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #3017