Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

guide: add documentation for trailing option arguments #2934

Merged
merged 1 commit into from
Feb 7, 2023
Merged

guide: add documentation for trailing option arguments #2934

merged 1 commit into from
Feb 7, 2023

Conversation

davidhewitt
Copy link
Member

Following the increased clarity around PyO3's handling of function signatures of 0.18.0, I wanted to add a section to the guide documenting the default-to-none behaviour for trailing Option<T> arguments.

@davidhewitt davidhewitt mentioned this pull request Feb 3, 2023
Closed
@davidhewitt davidhewitt added the CI-skip-changelog Skip checking changelog entry label Feb 3, 2023
@davidhewitt davidhewitt mentioned this pull request Feb 3, 2023
Closed
@davidhewitt
Copy link
Member Author

bors r+

@davidhewitt davidhewitt mentioned this pull request Feb 7, 2023
Merged
@bors
Copy link
Contributor

bors bot commented Feb 7, 2023

Build succeeded:

@bors bors bot merged commit 9e5c845 into PyO3:main Feb 7, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@birkenfeld birkenfeld birkenfeld left review comments

Assignees
No one assigned
Labels
CI-skip-changelog Skip checking changelog entry
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@davidhewitt @birkenfeld