-
Notifications
You must be signed in to change notification settings - Fork 792
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add generate-abi3-import-lib
feature to pyo3-ffi
#2309
Merged
davidhewitt
merged 2 commits into
PyO3:main
from
messense:pyo3-ffi-generate-abi3-import-lib
Apr 19, 2022
Merged
Add generate-abi3-import-lib
feature to pyo3-ffi
#2309
davidhewitt
merged 2 commits into
PyO3:main
from
messense:pyo3-ffi-generate-abi3-import-lib
Apr 19, 2022
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
LGTM. I didn't think someone would depend on |
messense
force-pushed
the
pyo3-ffi-generate-abi3-import-lib
branch
from
April 16, 2022 08:54
27eb6a3
to
bb2d018
Compare
There is an unrelated test failure on Python 3.11-dev. |
davidhewitt
reviewed
Apr 16, 2022
messense
force-pushed
the
pyo3-ffi-generate-abi3-import-lib
branch
from
April 16, 2022 13:19
bb2d018
to
31daa4b
Compare
messense
force-pushed
the
pyo3-ffi-generate-abi3-import-lib
branch
from
April 19, 2022 05:17
7338315
to
97a9121
Compare
davidhewitt
approved these changes
Apr 19, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
For PyO3/maturin#879