Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add generate-abi3-import-lib feature to pyo3-ffi #2309

Merged
merged 2 commits into from
Apr 19, 2022

Conversation

messense
Copy link
Member

@ravenexp
Copy link
Contributor

LGTM.

I didn't think someone would depend on pyo3-ffi directly.

@messense
Copy link
Member Author

@messense messense force-pushed the pyo3-ffi-generate-abi3-import-lib branch from 27eb6a3 to bb2d018 Compare April 16, 2022 08:54
@messense
Copy link
Member Author

---- test_anext_aiter stdout ----
thread 'test_anext_aiter' panicked at 'called `Result::unwrap()` on an `Err` value: ()', tests/test_proto_methods.rs:779:10
stack backtrace:
   0: rust_begin_unwind
             at /rustc/7737e0b5c4103216d6fd8cf941b7ab9bdbaace7c/library/std/src/panicking.rs:584:5
   1: core::panicking::panic_fmt
             at /rustc/7737e0b5c4103216d6fd8cf941b7ab9bdbaace7c/library/core/src/panicking.rs:143:14
   2: core::result::unwrap_failed
             at /rustc/7737e0b5c4103216d6fd8cf941b7ab9bdbaace7c/library/core/src/result.rs:1749:5
   3: core::result::Result<T,E>::unwrap
             at /rustc/7737e0b5c4103216d6fd8cf941b7ab9bdbaace7c/library/core/src/result.rs:1065:23
   4: test_proto_methods::test_anext_aiter
             at ./tests/test_proto_methods.rs:777:5
   5: test_proto_methods::test_anext_aiter::{{closure}}
             at ./tests/test_proto_methods.rs:750:1
   6: core::ops::function::FnOnce::call_once
             at /rustc/7737e0b5c4103216d6fd8cf941b7ab9bdbaace7c/library/core/src/ops/function.rs:227:5
   7: core::ops::function::FnOnce::call_once
             at /rustc/7737e0b5c4103216d6fd8cf941b7ab9bdbaace7c/library/core/src/ops/function.rs:227:5

There is an unrelated test failure on Python 3.11-dev.

Cargo.toml Outdated Show resolved Hide resolved
@messense messense force-pushed the pyo3-ffi-generate-abi3-import-lib branch from bb2d018 to 31daa4b Compare April 16, 2022 13:19
@messense
Copy link
Member Author

extension-module = []

extension-module = ["pyo3-build-config/extension-module", "pyo3-ffi/extension-module"]

Should we also add pyo3-build-config/extension-module to pyo3-ffi?

@messense messense force-pushed the pyo3-ffi-generate-abi3-import-lib branch from 7338315 to 97a9121 Compare April 19, 2022 05:17
@davidhewitt davidhewitt enabled auto-merge April 19, 2022 05:33
@davidhewitt davidhewitt merged commit 330fa78 into PyO3:main Apr 19, 2022
@messense messense deleted the pyo3-ffi-generate-abi3-import-lib branch April 19, 2022 06:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants