Apparently, PySet_Add does not steal a reference, hence we should for…

…get to clean up ours.
PyO3 · Jul 2, 2023 · a2594f9 · a2594f9
1 parent 135535e
commit a2594f9
Show file tree

Hide file tree

Showing 2 changed files with 3 additions and 2 deletions.
diff --git a/newsfragments/3286.fixed.md b/newsfragments/3286.fixed.md
@@ -0,0 +1 @@
+Fix memory leak when returning types converted into `PySet` internally, e.g. `HashSet` or `BTreeSet`.
diff --git a/src/types/set.rs b/src/types/set.rs
@@ -2,7 +2,7 @@
 use crate::types::PyIterator;
 use crate::{
     err::{self, PyErr, PyResult},
-    IntoPyPointer, Py,
+    Py,
 };
 use crate::{ffi, AsPyPointer, PyAny, PyObject, Python, ToPyObject};
 use std::ptr;
@@ -260,7 +260,7 @@ pub(crate) fn new_from_iter<T: ToPyObject>(
 
         for obj in elements {
             unsafe {
-                err::error_on_minusone(py, ffi::PySet_Add(ptr, obj.into_ptr()))?;
+                err::error_on_minusone(py, ffi::PySet_Add(ptr, obj.as_ptr()))?;
             }
         }
Original file line number	Diff line number	Diff line change
		@@ -0,0 +1 @@
		Fix memory leak when returning types converted into `PySet` internally, e.g. `HashSet` or `BTreeSet`.