Make invalid version info in pyproject.toml less fatal
#2417
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
6 tasks
|
According the spec: https://packaging.python.org/en/latest/specifications/pyproject-toml/#dynamic
the current behavior is spec compliant, change it to warn only may seem to resolve the error, it can resurface when user try to install a package from sdist (because wheel isn't avaiable for some reason), for eample when using |
messense
added a commit
that referenced
this pull request
Dec 30, 2024
…toml` (#2418) This PR implements the changes discussed in #2416 (comment) on top of #2417. Got this done faster than expected this morning, but won't have any time to incorporate feedback for the next ~ two days. Feel free to pull this in and butcher it any way you like. :) Thanks again for your fantastic work on maturin! 🍰 --------- Co-authored-by: messense <messense@icloud.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR is a simple fix #2416 by making invalid version information in
pyproject.tomlless fatal.Thank you for your great work on Maturin! 🍰