Fix platform tags when cross-compiling universal2 #2153
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When cross-compiling for
universal2-apple-darwin
, the platform tags of the resulting wheel were not properly derived. This is because with forcingtarget_triple
toNone
as before, it was not detected that we are in fact cross-compiling for a different target and thus the wheels were wrongly tagged for the host platform.To make the inference work, set
target_triple
to a valid triple instead.