Bump generated github actions workflow to v4 of up/download-artifact actions #1886
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✅ Deploy Preview for maturin-guide ready!Built without sensitive environment variables
To edit notification comments on pull requests, go to your Netlify site configuration. |
jeertmans
added a commit
to jeertmans/DiffeRT
that referenced
this pull request
Jan 8, 2024
jeertmans
added a commit
to jeertmans/DiffeRT
that referenced
this pull request
Jan 8, 2024
2 tasks
1 task
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Recently version 4 of the upload-artifact and download-artifact github actions have been published, introducing some breaking changes. This pull request changes the github actions scripts generated by
maturin generate-cito use v4 of the up/download-artifact actions, making the necessary changes to avoid deal with the breaking changes, mainly that artifact names have to be unique.I have tested the changes for the default targets in one of my projects, and they seem to work. I changed the emscripten part of the script to the best of my knowledge, but this is not tested.