Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix executemany with binary prefix #605

Merged
merged 4 commits into from
May 18, 2023
Merged

Conversation

methane
Copy link
Member

@methane methane commented May 18, 2023

Fix #494

@codecov
Copy link

codecov bot commented May 18, 2023

Codecov Report

Patch coverage: 100.00% and project coverage change: -0.04 ⚠️

Comparison is base (3517eb7) 88.90% compared to head (a7c27c5) 88.86%.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #605      +/-   ##
==========================================
- Coverage   88.90%   88.86%   -0.04%     
==========================================
  Files           7        7              
  Lines         568      548      -20     
==========================================
- Hits          505      487      -18     
+ Misses         63       61       -2     
Impacted Files Coverage Δ
src/MySQLdb/cursors.py 86.29% <100.00%> (-0.28%) ⬇️

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

@methane methane marked this pull request as ready for review May 18, 2023 08:52
@methane methane merged commit 62f0645 into PyMySQL:main May 18, 2023
@methane methane deleted the binary-prefix branch May 18, 2023 08:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

INSERT into json column on MySQL 8 with binary_prefix fails (succeeds for pymysql)
1 participant