Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Indicate unknown type for deserialization. #8

Merged
merged 1 commit into from
Dec 5, 2024

Conversation

BenediktBurger
Copy link
Contributor

If the type was unknown, you did not know, which type it was.

Now the error contains the name of the unknown type, such that you might register such a class.

Copy link
Contributor

@seb5g seb5g left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

make sense!

@seb5g seb5g merged commit 4355a2e into PyMoDAQ:0.0.x_dev Dec 5, 2024
@seb5g
Copy link
Contributor

seb5g commented Dec 5, 2024

@malik-irain I can see no tests were triggered here on this PR. I guess I didn't specify the trigger on pull reaquest in the actions. Could you make sure the 4 packages: pymodaq, pymodaq_data, utils and gui are behaving the same? thx

@BenediktBurger BenediktBurger deleted the improve-exception branch December 5, 2024 15:56
@BenediktBurger BenediktBurger mentioned this pull request Dec 5, 2024
@malik-irain
Copy link
Contributor

PR #11 should activate tests to be triggered on push, on pull requests and manually.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants