Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Backup pip environment #19

Merged
merged 5 commits into from
Feb 8, 2025

Conversation

malik-irain
Copy link
Contributor

Related to issue 440 from PyMoDAQ

Classes to create and manage pip environment backup files.

Copy link

codecov bot commented Jan 31, 2025

Codecov Report

Attention: Patch coverage is 57.42574% with 43 lines in your changes missing coverage. Please review.

Project coverage is 73.37%. Comparing base (6fb43d6) to head (0feccf6).
Report is 9 commits behind head on 0.0.x_dev.

Files with missing lines Patch % Lines
src/pymodaq_utils/environment.py 57.42% 43 Missing ⚠️
Additional details and impacted files
@@              Coverage Diff              @@
##           0.0.x_dev      #19      +/-   ##
=============================================
- Coverage      74.46%   73.37%   -1.09%     
=============================================
  Files             17       18       +1     
  Lines           1488     1589     +101     
=============================================
+ Hits            1108     1166      +58     
- Misses           380      423      +43     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Contributor

@seb5g seb5g left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could you use everywhere Path object and not a mix of os and Path! Thx

Copy link
Contributor

@seb5g seb5g left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

that's much nicer with Path objects!! still one conversation to resolve about the return type of you function

@seb5g seb5g merged commit f25a514 into PyMoDAQ:0.0.x_dev Feb 8, 2025
9 of 12 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants