Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature/pyproject layout #24

Merged
merged 8 commits into from
Feb 24, 2025
Merged

Feature/pyproject layout #24

merged 8 commits into from
Feb 24, 2025

Conversation

seb5g
Copy link
Contributor

@seb5g seb5g commented Feb 14, 2025

among other things:

  • implement pyproject.toml layout
  • dynamic versioning
  • update actions
  • moved plugin checker with src (to implement a console script out of it)

@seb5g seb5g requested a review from malik-irain February 14, 2025 13:36
@seb5g
Copy link
Contributor Author

seb5g commented Feb 14, 2025

@malik-irain could you check that all those modifications are still ok with the prupose of your last PR? I checked almost everything. Something bothering me is that reports is now generated within the src folder... could be done in .pymodaq maybe?
also please check the extra arguments are still working when using the console script defined in the pyproject file please!

@malik-irain
Copy link
Contributor

Everything works correctly!

As for the report location, the way it works now is they are generated in the folder where you execute the script:

cd pymodaq_plugin_manager/
python src/pymodaq_plugin_manager/compatibility_checker.py # will generate reports in ./reports
cd src/
python pymodaq_plugin_manager/compatibility_checker.py # will generate reports in ./reports
cd pymodaq_plugin_manager
python compatibility_checker.py # will generate reports in ./reports

I can modify the script so they are in .pymodaq/reports but as this project doesn't depends on any pymodaq package, it will not have the access to the config module. Meaning that the .pymodaq folder will be hardcoded. Is that ok?

@seb5g
Copy link
Contributor Author

seb5g commented Feb 17, 2025

I think it is fine as it is. I will accept the pr as is. It would be nice to include this in the gui if the plugin manager. That would be another pr

@seb5g seb5g merged commit 835dec6 into main Feb 24, 2025
@seb5g seb5g deleted the feature/pyproject_layout branch February 24, 2025 13:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants