Correct _get_parameters. #456
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The two versions of parameter parsing were not, in fact, equivalent. The
return types of `inspect.signature` and `inspect.getargspec` are, in
fact, subtly different.
See:
* https://docs.python.org/3/library/inspect.html#inspect.signature
* praw-dev/praw#541 (comment)
|
This looks correct to me @IanLee1521. Thoughts? |
|
Looks good. As an aside, there is talk of resurrecting inspect.getargspec() in Python 3.6: http://bugs.python.org/issue25486 |
|
Merged. Thanks! |
pointlessone
added a commit
to pointlessone/pep8
that referenced
this pull request
Dec 29, 2016
2.2.0 (2016-11-14) ------------------ Bugs: * Fixed E305 regression caused by PyCQA#400; PyCQA#593 2.1.0 (2016-11-04) ------------------ Changes: * Report E302 for blank lines before an "async def"; PyCQA#556 * Update our list of tested and supported Python versions which are 2.6, 2.7, 3.2, 3.3, 3.4 and 3.5 as well as the nightly Python build and PyPy. * Report E742 and E743 for functions and classes badly named 'l', 'O', or 'I'. * Report E741 on 'global' and 'nonlocal' statements, as well as prohibited single-letter variables. * Deprecated use of `[pep8]` section name in favor of `[pycodestyle]`; PyCQA#591 Bugs: * Fix opt_type AssertionError when using Flake8 2.6.2 and pycodestyle; PyCQA#561 * Require two blank lines after toplevel def, class; PyCQA#536 * Remove accidentally quadratic computation based on the number of colons. This will make pycodestyle faster in some cases; PyCQA#314 2.0.0 (2016-05-31) ------------------ Changes: * Added tox test support for Python 3.5 and pypy3 * Added check E275 for whitespace on `from ... import ...` lines; PyCQA#489 / PyCQA#491 * Added W503 to the list of codes ignored by default ignore list; PyCQA#498 * Removed use of project level `.pep8` configuration file; PyCQA#364 Bugs: * Fixed bug with treating `~` operator as binary; PyCQA#383 / PyCQA#384 * Identify binary operators as unary; PyCQA#484 / PyCQA#485 1.7.0 (2016-01-12) ------------------ Changes: * Reverted the fix in PyCQA#368, "options passed on command line are only ones accepted" feature. This has many unintended consequences in pep8 and flake8 and needs to be reworked when I have more time. * Added support for Python 3.5. (Issue PyCQA#420 & PyCQA#459) * Added support for multi-line config_file option parsing. (Issue PyCQA#429) * Improved parameter parsing. (Issues PyCQA#420 & PyCQA#456) Bugs: * Fixed BytesWarning on Python 3. (Issue PyCQA#459)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The two versions of parameter parsing were not, in fact, equivalent. The
return types of
inspect.signatureandinspect.getargspecare, infact, subtly different.
See:
* https://docs.python.org/3/library/inspect.html#inspect.signature
* praw-dev/praw#541 (comment)