Provide the --freeze parameter. Fixes #385 #392
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Closed
gilgamezh
approved these changes
May 5, 2020
README.rst
Outdated
|
|
||
| However, this has a bad side. If it happens that a dependency of your | ||
| project released a revision between the moment you run the tests and the | ||
| mement your project is deployed to the server, it may happen that you |
| """Dump venv contents to the indicated filepath.""" | ||
| logger.debug("running freeze to store in %r", filepath) | ||
| stdout = helpers.logged_exec([self.pip_exe, "freeze", "--all", "--local"]) | ||
| with open(filepath, "wt", encoding='utf8') as fh: |
There was a problem hiding this comment.
why are you adding t here? That's just the default
There was a problem hiding this comment.
Explicit better than implicit :).
Now seriously, I always write 't' or 'b' there, as the difference is getting bytes or unicode chars, which may be critical in the following handling of the file handler.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.