Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix buffer accessed out of bounds #2150

Closed
wants to merge 1 commit into from
Closed

Fix buffer accessed out of bounds #2150

wants to merge 1 commit into from
+20 −7

Conversation

rex4539
Copy link
Contributor

@rex4539 rex4539 commented Jan 19, 2025

Fixes

libi2pd/Identity.cpp:34:11: error: Buffer is accessed out of bounds: publicKey [bufferAccessOutOfBounds]
  memcpy (publicKey, buf, DEFAULT_IDENTITY_SIZE);
          ^

@orignal
Copy link
Contributor

orignal commented Jan 19, 2025

It sounds right. publickey refers to memory of DEFAULT_IDENTITY_SIZE.
There is no error here.

@orignal
Copy link
Contributor

orignal commented Jan 19, 2025

5e30193

@orignal orignal closed this Jan 19, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@rex4539 @orignal