Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

removed classifier_synchronization_period override #11

Open
wants to merge 2 commits into
base: production
Choose a base branch
from
Open

removed classifier_synchronization_period override #11

wants to merge 2 commits into from

Conversation

MartyEwings
Copy link

r10k postrun command is not called when using code manager disabling classifier scheduled sync results in the classifier never syncing automatically

r10k postrun command is not called when using codemanager disable classifier scheduled sync results in the classifier never syncing automatically
@npwalker
Copy link

@MartyEwings what version of PE? It definitely used to work and I thought that file sync now updated the classifier for the user?

@MartyEwings
Copy link
Author

I was using 2017.3, and the customer on the LTS

@MartyEwings
Copy link
Author

Think post environment hooks are how ur supposed to do this now

https://puppet.com/docs/pe/2016.4/code_mgr_custom.html#postenvironmenthooks

@npwalker
Copy link

@MartyEwings ah yea, so I've always disabled classifier sync and just told users to hit the refresh button in the console because even when you use the background sync it doesn't refresh for a web page that's already open.

However, I can get onboard with using the default and not disabling it at this point. I'd prefer we just remove those 4 lines altogether instead of commenting out though.

@MartyEwings
Copy link
Author

MartyEwings commented Nov 21, 2017

@npwalker Ok will do, main problem with that isn’t the classes, but if you have a new environment, it does not appear in the drop down when creating a new environment group until refresh occurs, and the button is hidden in existing node groups

@npwalker
Copy link

@MartyEwings environments aren't refreshed in an open console web page either. That still requires a full page refresh or a refresh classes button push.

@MartyEwings
Copy link
Author

@npwalker this wasn’t refreshing in my testing after restarts and code deploys, And full refreshes, basically didn’t seems to be any mechanism to auto refresh without pressing the button, if the auto refresh was disabled

@npwalker
Copy link

@MartyEwings yes if the classifier sync is off then the only way is to push the refresh classes button.

If classifier sync is on then you have a new option. Wait until the every 10 minute sync happens and then full page refresh.

I don't think that just be not disabling classifier sync causes environments to refresh outside of the 10 minute sync?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants