-
Notifications
You must be signed in to change notification settings - Fork 296
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fixes and additions #672
base: master
Are you sure you want to change the base?
Fixes and additions #672
Conversation
This allows the firmware driver to be discounted when not available (e.g. using KMS driver) (original commit by popcornmix popcornmix@b30fc83)
Signed-off-by: Jonas Karlman <jonas@kwiboo.se> (original commit by popcornmix popcornmix@6239ae1)
Addition: I tought I once made already a pull request of that so probably it flew out or is already incorporated... |
referencing to #637 |
just took a quick look at these patches. looking good in general, but can you squash the audio related commits into 1 (you've changed the signature of 2082445 contains some things that are local to your system that should be removed. from the looks of it, it's just the size of the buffer that needed fixing up. I'll give it another proper review after it's been cleaned up and will merge it one once it's ok, thanks. |
of course. |
may I ask to which part you are refering? |
the cmake defines and printf() change |
Some additions & fixes I made. I hope you could incorporate some. I jsut saw you did a lot of work there....