Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixes and additions #672

Open
wants to merge 10 commits into
base: master
Choose a base branch
from

Conversation

chincheta0815
Copy link

Some additions & fixes I made. I hope you could incorporate some. I jsut saw you did a lot of work there....

@chincheta0815
Copy link
Author

Addition: I tought I once made already a pull request of that so probably it flew out or is already incorporated...

@chincheta0815
Copy link
Author

referencing to #637

@opdenkamp
Copy link
Contributor

just took a quick look at these patches. looking good in general, but can you squash the audio related commits into 1 (you've changed the signature of AudioEnable() in 1 patch and reverted the changes in the next one for instance).
same for the Teufel vendor id ones.

2082445 contains some things that are local to your system that should be removed. from the looks of it, it's just the size of the buffer that needed fixing up.

I'll give it another proper review after it's been cleaned up and will merge it one once it's ok, thanks.

@chincheta0815
Copy link
Author

of course.
I already thought you might ask for something like that, but I wanted to know whether it will be worth the effort ;o)
I will try to make things "topic related".

@chincheta0815
Copy link
Author

2082445 contains some things that are local to your system that should be removed. from the looks of it, it's just the size of the buffer that needed fixing up.

may I ask to which part you are refering?

@opdenkamp
Copy link
Contributor

the cmake defines and printf() change

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants