Fix Torch God biome torch swap issue #2353
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Can confirm this fixes the issue but not sure if it opens any new exploits
Thanks to everyone who helped on discord
hakusaro
requested changes
May 28, 2021
| if (selectedItem.placeStyle != style) | ||
|
|
||
| if ((args.Player.TPlayer.BiomeTorchHoldStyle(style) != args.Player.TPlayer.BiomeTorchPlaceStyle(style)) | ||
| && (selectedItem.placeStyle != style)) |
There was a problem hiding this comment.
Suggested change
| && (selectedItem.placeStyle != style)) | |
| && (selectedItem.placeStyle != style)) |
sure thing |
I actually fixed it for you but your fork isn't writable to us so I can't push it :S |
Co-authored-by: Lucas Nicodemus <shank@shanked.me>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Can confirm this fixes the issue but not sure if it opens any new exploits
?????? HAVE YOU UPDATED THE CHANGELOG? ??????
not yetyesIssue: #2344