Annotation enhancements needed to support multiple selectors and target sources #3232
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
3 tasks
robcast
reviewed
Jul 24, 2020
| @@ -124,6 +130,10 @@ describe('AnnotationItem', () => { | |||
| expect(new AnnotationItem({ target: 'www.example.com/#xywh=10,10,100,200' }) | |||
| .fragmentSelector).toEqual([10, 10, 100, 200]); | |||
| }); | |||
| it('multiple selectors', () => { | |||
| expect(new AnnotationItem({ target: { selector: [{ type: 'FragmentSelector', value: 'www.example.com/#xywh=10,10,100,200' }] } }) | |||
There was a problem hiding this comment.
AFAIK the value of a FragmentSelector is just the fragment, i.e. value: 'xywh=10,10,100,200' ;-)
There was a problem hiding this comment.
Thanks for that @robcast. I've updated the test to reflect that.
56b4409 to
b1a03c8
Compare
Codecov Report
@@ Coverage Diff @@
## master #3232 +/- ##
==========================================
+ Coverage 90.54% 90.64% +0.09%
==========================================
Files 187 187
Lines 3153 3152 -1
==========================================
+ Hits 2855 2857 +2
+ Misses 298 295 -3
Continue to review full report at Codecov.
|
cbeer
approved these changes
Jul 27, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Based off of discussion in ProjectMirador/mirador-annotations#21 and ProjectMirador/mirador-annotations#20