Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

enhancement/issue 176 add bluesky link to social tray component #179

Open
wants to merge 3 commits into
base: main
Choose a base branch
from
+18 −3
Open

enhancement/issue 176 add bluesky link to social tray component #179

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
38079f9
add bluesky link to social tray component
Feb 6, 2025
ab4888d
fixed a typo and made sure the social-tray tests pass
Feb 10, 2025
f8389ec
Merge branch 'ProjectEvergreen:main' into social-tray-component-add-b…
BDFL669 Feb 10, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions src/assets/bluesky.svg
View file
Open in desktop
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
8 changes: 8 additions & 0 deletions src/components/social-tray/social-tray.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,6 +2,7 @@ import styles from "./social-tray.module.css";
import discordIcon from "../../assets/discord.svg?type=raw";
import githubIcon from "../../assets/github.svg?type=raw";
import twitterIcon from "../../assets/twitter-logo.svg?type=raw";
import blueskyIcon from "../../assets/bluesky.svg?type=raw";

export default class SocialTray extends HTMLElement {
connectedCallback() {
Expand All @@ -18,6 +19,13 @@ export default class SocialTray extends HTMLElement {
${discordIcon}
</a>
</li>

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

the formatting here looks off, not sure if you had a chance to run prettier before submitting? You can run npm run format to automatically format, otherwise CI will fail when run here.

edit: hmm, looks like it didn't fail, that's interesting. Well, if npm run format doesn't fix it, could we try and make the changes here match the existing formatting conventions of other social tray icon links? Thanks!

<li class="${styles.socialIcon}">
<a href="https://bsky.app/profile/projectevergreen.bsky.social" title="Bluesky"
style="display: inline-block; transform: scale(1.7) translateY(-2px);">
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

based on some quick testing, it didn't seem like the display: inline-block was needed at least.
Screenshot 2025-02-06 at 12 39 11 PM

Otherwise, is there anyway we can get the rest of this styling back into the SVG at all? I didn't have to do it for other SVG icons in the social tray, so hoping we don't have to do a one-off styles here ideally.

If it is needed, I would probably suggest we just add a specific CSS class for this in social-tray.module.css

${blueskyIcon}
</a>
</li>

<li class="${styles.socialIcon}">
<a href="https://twitter.com/PrjEvergreen" title="Twitter">
Expand Down
Loading