Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Enhancement/issue 24 refactor definitions sharing #70

Merged
merged 2 commits into from
Jul 13, 2022
Merged

Enhancement/issue 24 refactor definitions sharing #70

merged 2 commits into from
Jul 13, 2022

Conversation

thescientist13
Copy link
Member

@thescientist13 thescientist13 commented Jun 29, 2022 •
edited
Loading

Related Issue

resolves #24 and #53

Summary of Changes

  1. Refactor definitions to not be shared and global (pass by reference)
  2. Added test case using add test case for bare import specifiers #53

TODO

  1. Sanity test downstream with a project (Greenwood)
  2. Should I move everything except rendetToString and renderFromHTML to a lib.js?
  3. Make a discussion thinking about how best to plan the future technical design, or at least to start the conversation - Technical Design and Architecture #74

@thescientist13 thescientist13 added the enhancement Improvement to existing functionality label Jun 29, 2022
@thescientist13 thescientist13 force-pushed the enhancement/issue-24-refactor-definitions-sharing branch from 7b5edcc to de24d25 Compare July 12, 2022 12:35
@thescientist13 thescientist13 merged commit 591ad94 into master Jul 13, 2022
@thescientist13 thescientist13 deleted the enhancement/issue-24-refactor-definitions-sharing branch July 13, 2022 00:25
@thescientist13 thescientist13 linked an issue Jul 13, 2022 that may be closed by this pull request
add test case for bare import specifiers #53
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
enhancement Improvement to existing functionality
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

add test case for bare import specifiers refactor custom element definitions being shared
1 participant
@thescientist13