-
Notifications
You must be signed in to change notification settings - Fork 10
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Feature/issue 954 puppeteer plugin #960
Merged
thescientist13
merged 23 commits into
release/0.26.0
from
feature/issue-954-puppeteer-plugin
Jul 16, 2022
Merged
Feature/issue 954 puppeteer plugin #960
thescientist13
merged 23 commits into
release/0.26.0
from
feature/issue-954-puppeteer-plugin
Jul 16, 2022
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…teer logic into plugin
9 tasks
What's odd about the windows failure is that it the Puppeteer rendering is only broken for the home page ( Some thoughts off the top of my head
|
…ctEvergreen/greenwood into feature/issue-954-puppeteer-plugin
…ctEvergreen/greenwood into feature/issue-954-puppeteer-plugin
thescientist13
added a commit
that referenced
this pull request
Jul 27, 2022
* puppeteer renderer plugin and migrate resource plugin * introduce custom function option for renderer plugins and moved puppeteer logic into plugin * made WCC default prerender * stabilize specs * upgrade latest version of puppeteer * add specs for puppeteer renderer plugin * clarify it block * stablize all CLI specs * fix spelling mistake * comments for init specs * restore graphql specs with dependency on puppeteer plugin when prerendering * restore all specs and adjust thresholds * misc PR cleanup * fix lint and clean up package jsons * fix lint and clean up package jsons * upgrade latest version of WCC * update docs to reflect prerendering with WCC and cross dependencies with Puppeteer * fix and restore puppeteer based inline javascript execution specs * fix typo in specs * cross platform puppeteer intercepting support * refactor preRenderCompilationWorker to be async Promise.all
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
breaking
CLI
dependencies
Pull requests that update a dependency file
documentation
Greenwood specific docs
feature
New feature or request
Plugins
Greenwood Plugins
SSR
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related Issue
resolves #954
Summary of Changes
customUrl
) based prerender only plugin packageWCC
defaultprerenderer
TODO
xit
in puppeteer plugin)export
is wrong (also fix spellings of Uaer and @greenwod) - need to make an issue - Import CommonJS plugin namedexport
is spelled wrong 🤦 #961preRenderCompilationWorker
should / could run as aPromise.all
?Questions / Backlog Tracking
<app-header>
if the dependency JS has not been found / provided) (just log a warning instead) - handle usage of unregistered custom elements wcc#25customUrl
in development - tracked in my backlogprerender
vs SSR vs CSR) #951