Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

include puppeteer version expectation in output and only auto-detect on build or serve commands #928

Merged
merged 1 commit into from
Apr 2, 2022
Merged

include puppeteer version expectation in output and only auto-detect on build or serve commands #928

merged 1 commit into from
Apr 2, 2022

Conversation

thescientist13
Copy link
Member

Related Issue

#916

Summary of Changes

  1. Only detect / install puppeteer for build / serve tasks
  2. Include puppeteer version in error message output

@thescientist13 thescientist13 mentioned this pull request Apr 2, 2022
Merged
21 tasks
@thescientist13 thescientist13 added enhancement Improve something existing (e.g. no docs, new APIs, etc) CLI SSR v0.25.0 labels Apr 2, 2022
@thescientist13 thescientist13 force-pushed the enhancement/issue-916-improve-detection-timing-and-messaging branch from a6ea46c to 477ced0 Compare April 2, 2022 14:39
@thescientist13 thescientist13 merged commit 0edec28 into release/0.25.0 Apr 2, 2022
@thescientist13 thescientist13 deleted the enhancement/issue-916-improve-detection-timing-and-messaging branch April 2, 2022 14:51
@thescientist13 thescientist13 changed the title include version expectation in output and only auto-detect on build o… include version expectation in output and only auto-detect on build or serve Apr 2, 2022
@thescientist13 thescientist13 changed the title include version expectation in output and only auto-detect on build or serve include puppeteer version expectation in output and only auto-detect on build or serve commands Apr 2, 2022
@thescientist13 thescientist13 linked an issue Apr 2, 2022 that may be closed by this pull request
auto-detect and install puppeteer dependency for default prerendering #916
Closed
5 tasks
thescientist13 added a commit that referenced this pull request Apr 7, 2022
@thescientist13
include version expectation in output and only auto-detect on build o…
0718c14 
…r serve command (#928)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
alpha.3 CLI enhancement Improve something existing (e.g. no docs, new APIs, etc) SSR v0.25.0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

auto-detect and install puppeteer dependency for default prerendering
1 participant
@thescientist13