Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Feature/issue 856 hybrid workspace with static router #874

Merged
merged 4 commits into from
Feb 5, 2022
Merged

Feature/issue 856 hybrid workspace with static router #874

merged 4 commits into from
Feb 5, 2022

Conversation

thescientist13
Copy link
Member

@thescientist13 thescientist13 commented Feb 2, 2022 •
edited
Loading

Related Issue

resolves #856

Summary of Changes

  1. Have Greenwood autodetect SSG / SSR / SPA automatically, and removed mode configuration option
  2. For MPA routing, introduced staticRouter configuration specifically to retain that feature
  3. Updated docs and specs to reflect updated configuration and layout patterns

TODO

  1. Rename test case filenames away from including "mode"
  2. See if walkDirectoryForPages can be refactored some more

@thescientist13 thescientist13 added documentation Greenwood specific docs CLI breaking feature New feature or request labels Feb 2, 2022
@thescientist13 thescientist13 linked an issue Feb 5, 2022 that may be closed by this pull request
have Greenwood auto detect project (mode) and expose client router option ("fluid" workspaces) #856
Closed
5 tasks
@thescientist13 thescientist13 merged commit 907a0a6 into release/0.23.0 Feb 5, 2022
@thescientist13 thescientist13 deleted the feature/issue-856-hybrid-workspace-with-static-router branch February 5, 2022 00:35
thescientist13 added a commit that referenced this pull request Feb 12, 2022
@thescientist13
Feature/issue 856 hybrid workspace with static router (#874)
cee727d 
* refactor SSG and SSR modes

* refactor out mode completely and introduce staticRouter

* hybrid documentation updates and remove mode configuration docs

* rename specs
@thescientist13 thescientist13 mentioned this pull request Feb 17, 2022
Closed
5 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
breaking CLI documentation Greenwood specific docs feature New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

have Greenwood auto detect project (mode) and expose client router option ("fluid" workspaces)
1 participant
@thescientist13