Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feature/AWS Architect adapter #8

Draft
wants to merge 6 commits into
base: main
Choose a base branch
from
Draft

Conversation

thescientist13
Copy link
Member

@thescientist13 thescientist13 commented Feb 21, 2025

ProjectEvergreen/greenwood#1142

Summary

  1. AWS adapter with Architect - https://y9ytogm4l7.execute-api.us-east-1.amazonaws.com/

See another demo implementation here - AnalogStudiosRI/api#44)

TODO

  1. SSR pages (can't end route with /?
    • still seems to work as /product, but then breaks in app because of <a> tags)
    sandbox failed! Validation error:
    - Invalid @http path (cannot end with '/'): get /products/
    Error: Validation error:
    - Invalid @http path (cannot end with '/'): get /products/
        at format (/Users/owenbuckley/Workspace/project-evergreen/greenwood-demo-adapter-aws/node_modules/@architect/inventory/src/lib/error-fmt.js:15:13)
        at /Users/owenbuckley/Workspace/project-evergreen/greenwood-demo-adapter-aws/node_modules/@architect/inventory/src/index.js:92:18
        at process.processTicksAndRejections (node:internal/process/task_queues:90:21)
  2. latest runtime
  3. dynamic / wildcard method
  4. make Arc configuration dynamic (not hardcoded)
  5. this warning
    ⚠️ Warning: Lambda treeshaking does not support dynamic imports, dependency may not be installed: /Users/owenbuckley/Workspace/project-evergreen/greenwood-demo-adapter-aws/.aws-output/routes/products imports 'moduleUrl'
  6. README updates
  7. Production deployment GitHub action

Thoughts / Questions (Arc Preset)

  1. not really a nice / clean way to programmatically generate a app.arc file, is there?
    • or is there an @import kind of thing?
    • javascript config file?
    • handle basePath
  2. wild card method instead of having to specify GET / POST / etc - can use any
  3. had to use /* to handle SSR pages routes, since @http can't end in /, not sure if it's the best?
  4. Does Architect support Cloudfront / Route 53? - No, its manual it seems - https://arc.codes/docs/en/guides/domains/registrars/route53-and-cloudfront

@thescientist13 thescientist13 added documentation Improvements or additions to documentation enhancement New feature or request question Further information is requested needs upstream labels Feb 21, 2025
@thescientist13 thescientist13 self-assigned this Feb 21, 2025
@thescientist13 thescientist13 changed the title feature/AWS Arc adapter feature/AWS Architect adapter Feb 21, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation Improvements or additions to documentation enhancement New feature or request needs upstream question Further information is requested
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant