Revert #2795: Rewrite cucumber test caching, Tests Failing At Random #2934
+1,136
−863
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This reverts commit 7d124ce.
MoKob
suggested changes
Sep 20, 2016
| @@ -620,7 +620,7 @@ Feature: Turn Lane Guidance | |||
| | a,d | hwy,hwy | depart,arrive | , | | |||
| | a,e | hwy,ramp,ramp | depart,off ramp slight right,arrive | ,straight:false straight:false straight;slight right:true slight right:true, | | |||
|
|
|||
| @todo | |||
| @bug @todo | |||
There was a problem hiding this comment.
seems like a few additional bug tags got back in here?
| @@ -422,7 +422,7 @@ Feature: Turn Lane Guidance | |||
| | waypoints | route | turns | lanes | | |||
| | a,e | main,main,main,main | depart,use lane straight,continue right,arrive | ,left:false straight:false straight:false straight:false straight:true straight:true right:false,straight:false straight:false right:false right:true right:true, | | |||
|
|
|||
| @anticipate @todo @2661 | |||
| @anticipate @todo @bug @2661 | |||
| Feature: Known bugs | ||
|
|
||
| Background: | ||
| Given the profile "testbot" |
There was a problem hiding this comment.
is that feature designated to do something? Right now it seems completely empty. If we want to keep it, we should move known bugs here
| @@ -173,7 +173,7 @@ Feature: Via points | |||
| | c,d,a | abc,bd,bd,bd,abc,abc | | |||
|
|
|||
| # See issue #2349 | |||
| @todo | |||
| @bug @todo | |||
7 tasks
First step I tried replicating this on OS X, but can't. Next I will try linux... |
2 tasks
|
I'm still unable to replicate on my linux machine. Sounds like @oxidase has been able to replicate on linux only with a release build and 500ms timeout (refs #2936). So, I think this revert should be paused and the focus instead put on testing the fix at #2936. (/cc @daniel-j-h can you test?) |
|
We are going with #2936 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The Cucumber caching PR @springmeyer merged into master yesterday (ref. #2795) does not work. Invoking
npm testmultiple times (so we hit the cache) lets tests fail at random and only sometimes.Here is an example (specific tests are not important, write after end error is):
https://gist.github.com/daniel-j-h/d73b4fcea574e61f1815505f1aae44be
Reverting this commit to get a working master again.