-
Notifications
You must be signed in to change notification settings - Fork 3.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Better caching for cucumber #2745
Comments
I think a new much simpler caching scheme will work better:
That means we will only cache the |
Just noticed another side effect of this, so 👍 to using some directory structure:
|
Good idea to improve this. But why don't you want to cache osrm files? That means you will have to run extraction and contraction again even if the binaries didn't change at all. |
Yes caching OSRM files is desirable but the dependencies are just complicated to track. Maybe the following scheme would also work:
I realized just caching the OSM files will not give us a big speed-up since we need to generate them anyway internally (to fill the lookup tables for translating names). |
Currently cucumber caches files depending on the hash of
osrm-contract
,osrm-extract
and the pre-processing tools. However this cache is never cleared if the hash of any dependency changes.This leads to big problems on travis since we cache
test/cache
and this file just keeps growing util we can't upload it anymore.Furthermore we put all files in a single directory, which makes path lockups notoriously slow. So we should nest the directories.
The text was updated successfully, but these errors were encountered: