Upgrade PostgreSQL to 14.5 #89
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
plural
reviewed
Oct 26, 2022
|
Right now we don't need to expose the port at all - the app is able to
connect to the db just fine.
…On Wed, Oct 26, 2022, 7:56 AM haradan ***@***.***> wrote:
***@***.**** commented on this pull request.
------------------------------
In docker-compose.override.yml
<#89 (comment)>:
> @@ -5,3 +5,6 @@ services:
app:
ports:
- "3000:3000"
+ db:
I'll change it to one that won't conflict with an installation on the
host. It's useful to be able to connect to it during development.
—
Reply to this email directly, view it on GitHub
<#89 (comment)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/AADA2EX3JP4XJ4WX5MHKAMLWFETAHANCNFSM6AAAAAARGPTWG4>
.
You are receiving this because you commented.Message ID:
***@***.***>
|
If we don't expose it, how do you connect to PostgreSQL with a client locally? Note that docker-compose.override.yml is only used for local development. |
|
I use docker-compose exec app rails:db to get a psql instance. If this is just for local dev, let's not expose the port in the config. One can always do that locally. |
plural
approved these changes
Oct 26, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is intended to be done with the scripts in PR #88.