added gsub for fancy quotes #370
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Yep, i have seen some similar ordering issues when working on the pairing fixes. This helped me with part of the testing setup: https://mixandgo.com/learn/ruby/let-vs-let! I do think we have some refactoring we can do here to make sure things are more isolated, though. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Always Be Running doesn't like the fancy quotes we have for runners like Kit, Loup, Ken, etc.
Rather than handle it everywhere, this PR just updates the quotes to be ABR friendly when doing the JSON export.
I can't seem to get the ABR export option to work when testing live, so for now this is just a JSON fix.
Small test case issue for later: the ordering of the single sided swiss tests here influences the pairing tests. Namely if the test I created runs after the original single sided swiss test, then the pairings test starts failing, but moving the quotes test earlier resolves that issue.