Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Round timer improvements #107

Merged
merged 16 commits into from
Dec 17, 2022
Merged

Round timer improvements #107

merged 16 commits into from
Dec 17, 2022

Conversation

haradan
Copy link
Contributor

@haradan haradan commented Dec 15, 2022 •
edited
Loading

Add type of round to timer message (swiss/double elim).
Add message to fullscreen timer.
Exit fullscreen timer with a close button rather than by clicking anywhere.
Distinguish state of round not started yet for fullscreen timer view.

haradan added 16 commits December 15, 2022 00:54
@haradan
Add more information to fullscreen round timer, fix width
1169ca3
@haradan
Add round format to timer information
56a5e36
@haradan
Fix timer display message in tests
a7e8f08
@haradan
Show time in round in fullscreen when timer not started
8311cf4
@haradan
Use a close button for the fullscreen timer
05032c3
@haradan
Align fullscreen timer text left to stop it popping around on Mac Safari
738f1a5
@haradan
Fix margin around timer close button at small screen sizes
0f7b1f9
@haradan
Use javascript:history.back() for timer close button
40d2297
@haradan
Tweak padding on fullscreen timer
4895c0d
@haradan
Make margin on fullscreen timer header relative to viewport
cc569c4
@haradan
Reduce padding a bit on fullscreen timer
e22b4d4
@haradan
Reduce padding more as Mac Safari font doesn't quite fit and doesn't …
78ea182 
…look good centred
@haradan
Fix width of numbers span to avoid font making it pop onto next line
51f77d6
@haradan
Align numbers to left in span
09eb422
@haradan
Fix width of numbers span in non-fullscreen timer
b2ebf54
@haradan
Comment to explain sizing relative to viewport width
642426d
@plural
Copy link
Contributor

plural commented Dec 17, 2022

This is swell. Thanks!

@plural plural merged commit 5c3bdf1 into main Dec 17, 2022
@haradan haradan deleted the round-timer-improvements branch January 2, 2023 17:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@haradan @plural