Skip to content

Commit

Permalink
Set side scores properly for SSS ties & IDs. (#379)
Browse files Browse the repository at this point in the history
  • Loading branch information
plural authored Jan 18, 2025
1 parent 8697cb5 commit ef7d89b
Show file tree
Hide file tree
Showing 2 changed files with 21 additions and 2 deletions.
4 changes: 2 additions & 2 deletions app/helpers/pairings_helper.rb
Original file line number Diff line number Diff line change
Expand Up @@ -83,8 +83,8 @@ def presets(pairing)
return [
{ score1_corp: 0, score2_corp: 3, score1_runner: 0, score2_runner: 0, intentional_draw: false,
label: 'Corp Win' },
{ score1_corp: 1, score2_corp: 0, score1_runner: 0, score2_runner: 1, intentional_draw: false, label: 'Tie' },
{ score1_corp: 1, score2_corp: 0, score1_runner: 0, score2_runner: 1, intentional_draw: true,
{ score1_corp: 0, score2_corp: 1, score1_runner: 1, score2_runner: 0, intentional_draw: false, label: 'Tie' },
{ score1_corp: 0, score2_corp: 1, score1_runner: 1, score2_runner: 0, intentional_draw: true,
label: 'Intentional Draw' },
{ score1_corp: 0, score2_corp: 0, score1_runner: 3, score2_runner: 0, intentional_draw: false,
label: 'Runner Win' }
Expand Down
19 changes: 19 additions & 0 deletions spec/helpers/pairings_helper_spec.rb
Original file line number Diff line number Diff line change
Expand Up @@ -23,6 +23,25 @@
)
end
end

context 'when player 1 is runner' do
let(:pairing) { create(:pairing, stage:, side: :player1_is_runner) }

it 'returns single-sided swiss defaults' do
expect(helper.presets(pairing)).to eq(
[
{ score1_corp: 0, score2_runner: 0, score1_runner: 0, score2_corp: 3, intentional_draw: false,
label: 'Corp Win' },
{ score1_corp: 0, score2_runner: 0, score1_runner: 1, score2_corp: 1, intentional_draw: false,
label: 'Tie' },
{ score1_corp: 0, score2_runner: 0, score1_runner: 1, score2_corp: 1, intentional_draw: true,
label: 'Intentional Draw' },
{ score1_corp: 0, score2_runner: 0, score1_runner: 3, score2_corp: 0, intentional_draw: false,
label: 'Runner Win' }
]
)
end
end
end

describe '#presets' do
Expand Down

0 comments on commit ef7d89b

Please sign in to comment.