Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

245 Update tutorials with new API (part 2) #253

Merged
merged 15 commits into from
Jul 12, 2021
Merged

Conversation

yiheng-wang-nv
Copy link
Contributor

@yiheng-wang-nv yiheng-wang-nv commented Jul 7, 2021

Signed-off-by: Yiheng Wang vennw@nvidia.com

Partially fixes #245 .

Description

This PR modifies the remnant examples in modules (as mentioned in #246 ).

Status

Ready

Checks

  • Notebook runs automatically ./runner [-p <regex_pattern>]

Signed-off-by: Yiheng Wang <vennw@nvidia.com>
@review-notebook-app
Copy link

Check out this pull request on  ReviewNB

See visual diffs & provide feedback on Jupyter Notebooks.


Powered by ReviewNB

Signed-off-by: Yiheng Wang <vennw@nvidia.com>
@yiheng-wang-nv yiheng-wang-nv requested a review from Nic-Ma July 7, 2021 15:04
yiheng-wang-nv and others added 2 commits July 7, 2021 23:35
@yiheng-wang-nv
Copy link
Contributor Author

yiheng-wang-nv commented Jul 7, 2021

Hi @SachidanandAlle , could you please help to update the deepgrow/ignite/handler.py (https://github.com/Project-MONAI/tutorials/blob/master/deepgrow/ignite/handler.py) to meet the decollate changes? Thanks!

@SachidanandAlle
Copy link
Contributor

I suggest we discontinue this Handler.. Developer can use existing ones to write dice and dump images..

@yiheng-wang-nv
Copy link
Contributor Author

yiheng-wang-nv commented Jul 7, 2021

I suggest we discontinue this Handler.. Developer can use existing ones to write dice and dump images..

Do you mean remove the file handler.py? Or could you please help to update the tutorial directly?

@SachidanandAlle
Copy link
Contributor

Yes..

yiheng-wang-nv and others added 5 commits July 9, 2021 10:44
Signed-off-by: Yiheng Wang <vennw@nvidia.com>
Signed-off-by: Yiheng Wang <vennw@nvidia.com>
Signed-off-by: Yiheng Wang <vennw@nvidia.com>
Copy link
Contributor

@Nic-Ma Nic-Ma left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the quick update, I put some comments inline.
Others look good to me.

Thanks.

yiheng-wang-nv and others added 4 commits July 12, 2021 11:29
Signed-off-by: Yiheng Wang <vennw@nvidia.com>
Signed-off-by: Yiheng Wang <vennw@nvidia.com>
Signed-off-by: Yiheng Wang <vennw@nvidia.com>
Copy link
Contributor

@Nic-Ma Nic-Ma left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the quick update.
Looks good to me now.
@wyli could you please help double confirm it?

Thanks in advance.

@Nic-Ma Nic-Ma requested a review from wyli July 12, 2021 10:17
Copy link
Contributor

@wyli wyli left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me

@wyli wyli merged commit 70ac974 into master Jul 12, 2021
@wyli wyli deleted the 245-update-with-new-api-part2 branch July 12, 2021 12:47
boneseva pushed a commit to boneseva/MONAI-tutorials that referenced this pull request Apr 21, 2024
* update with new api

Signed-off-by: Yiheng Wang <vennw@nvidia.com>

* fix pep8 lr

Signed-off-by: Yiheng Wang <vennw@nvidia.com>

* fix format error

Signed-off-by: Yiheng Wang <vennw@nvidia.com>

* update with decollate

Signed-off-by: Yiheng Wang <vennw@nvidia.com>

* replace to use 0.6.0

Signed-off-by: Yiheng Wang <vennw@nvidia.com>

* update inverse example

Signed-off-by: Yiheng Wang <vennw@nvidia.com>

* update transfer mmar

Signed-off-by: Yiheng Wang <vennw@nvidia.com>

* update with new api for jupyter_utils.ipynb

Signed-off-by: Yiheng Wang <vennw@nvidia.com>

* fix pep8

Signed-off-by: Yiheng Wang <vennw@nvidia.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Update all the examples & notebooks to use new APIs
4 participants