-
Notifications
You must be signed in to change notification settings - Fork 709
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
245 Update tutorials with new API (part 2) #253
Conversation
Signed-off-by: Yiheng Wang <vennw@nvidia.com>
Check out this pull request on See visual diffs & provide feedback on Jupyter Notebooks. Powered by ReviewNB |
Signed-off-by: Yiheng Wang <vennw@nvidia.com>
Signed-off-by: Yiheng Wang <vennw@nvidia.com>
Hi @SachidanandAlle , could you please help to update the |
I suggest we discontinue this Handler.. Developer can use existing ones to write dice and dump images.. |
Do you mean remove the file |
Yes.. |
Signed-off-by: Yiheng Wang <vennw@nvidia.com>
Signed-off-by: Yiheng Wang <vennw@nvidia.com>
Signed-off-by: Yiheng Wang <vennw@nvidia.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for the quick update, I put some comments inline.
Others look good to me.
Thanks.
Signed-off-by: Yiheng Wang <vennw@nvidia.com>
Signed-off-by: Yiheng Wang <vennw@nvidia.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for the quick update.
Looks good to me now.
@wyli could you please help double confirm it?
Thanks in advance.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to me
* update with new api Signed-off-by: Yiheng Wang <vennw@nvidia.com> * fix pep8 lr Signed-off-by: Yiheng Wang <vennw@nvidia.com> * fix format error Signed-off-by: Yiheng Wang <vennw@nvidia.com> * update with decollate Signed-off-by: Yiheng Wang <vennw@nvidia.com> * replace to use 0.6.0 Signed-off-by: Yiheng Wang <vennw@nvidia.com> * update inverse example Signed-off-by: Yiheng Wang <vennw@nvidia.com> * update transfer mmar Signed-off-by: Yiheng Wang <vennw@nvidia.com> * update with new api for jupyter_utils.ipynb Signed-off-by: Yiheng Wang <vennw@nvidia.com> * fix pep8 Signed-off-by: Yiheng Wang <vennw@nvidia.com>
Signed-off-by: Yiheng Wang vennw@nvidia.com
Partially fixes #245 .
Description
This PR modifies the remnant examples in
modules
(as mentioned in #246 ).Status
Ready
Checks
./runner [-p <regex_pattern>]