Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add time/memory benchmark for maisi #1879

Merged
merged 34 commits into from
Nov 24, 2024
Merged

Add time/memory benchmark for maisi #1879

merged 34 commits into from
Nov 24, 2024

Conversation

Can-Zhao
Copy link
Contributor

@Can-Zhao Can-Zhao commented Nov 15, 2024 •
edited
Loading

Fixes # .

Description

A few sentences describing the changes proposed in this pull request.

Checks

  • Avoid including large-size files in the PR.
  • Clean up long text outputs from code cells in the notebook.
  • For security purposes, please check the contents and remove any sensitive info such as user names and private key.
  • Ensure (1) hyperlinks and markdown anchors are working (2) use relative paths for tutorial repo files (3) put figure and graphs in the ./figure folder
  • Notebook runs automatically ./runner.sh -t <path to .ipynb file>

Can-Zhao and others added 7 commits November 15, 2024 08:50
@Can-Zhao
add time cost and gpu memory to readme asn add corresponding configs
cd5e398 
Signed-off-by: Can-Zhao <canz@nvidia.com>
@Can-Zhao
add time cost and gpu memory to readme asn add corresponding configs
c78bf7b 
Signed-off-by: Can-Zhao <canz@nvidia.com>
@pre-commit-ci
[pre-commit.ci] auto fixes from pre-commit.com hooks
01374e5 
for more information, see https://pre-commit.ci
@Can-Zhao
format
f563162 
Signed-off-by: Can-Zhao <canz@nvidia.com>
@Can-Zhao
format
c802a73 
Signed-off-by: Can-Zhao <canz@nvidia.com>
@Can-Zhao
format
aaf5710 
Signed-off-by: Can-Zhao <canz@nvidia.com>
@pre-commit-ci
[pre-commit.ci] auto fixes from pre-commit.com hooks
99c5ad7 
for more information, see https://pre-commit.ci
@Can-Zhao Can-Zhao marked this pull request as ready for review November 15, 2024 09:06
@Can-Zhao Can-Zhao requested a review from KumoLiu November 19, 2024 06:41
@Can-Zhao
add min requirement and VAE time table
267d5e1 
Signed-off-by: Can-Zhao <volcanofly@gmail.com>
KumoLiu
KumoLiu reviewed Nov 21, 2024
View reviewed changes
Copy link
Contributor

@KumoLiu KumoLiu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you very much for such a comprehensive addition.
Leave several comments inline.

generation/maisi/README.md Outdated Show resolved Hide resolved
generation/maisi/README.md Outdated Show resolved Hide resolved
generation/maisi/configs/config_infer_16g_256x256x128.json Outdated Show resolved Hide resolved
generation/maisi/scripts/inference.py Show resolved Hide resolved
generation/maisi/scripts/sample.py Show resolved Hide resolved
Can-Zhao and others added 13 commits November 21, 2024 18:58
@Can-Zhao
add details in readme
504a14b 
Signed-off-by: Can-Zhao <volcanofly@gmail.com>
@Can-Zhao
add details in readme
0d2cf00 
Signed-off-by: Can-Zhao <volcanofly@gmail.com>
@Can-Zhao
add details in readme
68f1f22 
Signed-off-by: Can-Zhao <volcanofly@gmail.com>
@Can-Zhao
add details in readme
27b2129 
Signed-off-by: Can-Zhao <volcanofly@gmail.com>
@Can-Zhao
add paper
3418a9e 
Signed-off-by: Can-Zhao <volcanofly@gmail.com>
@pre-commit-ci
[pre-commit.ci] auto fixes from pre-commit.com hooks
c4f7b76 
for more information, see https://pre-commit.ci
@Can-Zhao
grammar
69989b9 
Signed-off-by: Can-Zhao <volcanofly@gmail.com>
@Can-Zhao
Merge branch 'maisi_readme' of https://github.com/Can-Zhao/tutorials …
62e688c 
…into maisi_readme
@Can-Zhao
grammar
f43d3d5 
Signed-off-by: Can-Zhao <volcanofly@gmail.com>
@Can-Zhao
grammar
41dabe4 
Signed-off-by: Can-Zhao <volcanofly@gmail.com>
@pre-commit-ci
[pre-commit.ci] auto fixes from pre-commit.com hooks
c044c17 
for more information, see https://pre-commit.ci
@Can-Zhao
grammar
5b5b01e 
Signed-off-by: Can-Zhao <volcanofly@gmail.com>
@Can-Zhao
Merge branch 'maisi_readme' of https://github.com/Can-Zhao/tutorials …
047fb28 
…into maisi_readme
@Can-Zhao
grammar
f4c40fc 
Signed-off-by: Can-Zhao <volcanofly@gmail.com>
@Can-Zhao
grammar
d01c717 
Signed-off-by: Can-Zhao <volcanofly@gmail.com>
@Can-Zhao
adjust infer parameters
5414b92 
Signed-off-by: Can-Zhao <volcanofly@gmail.com>
@Can-Zhao
grammar
67269c6 
Signed-off-by: Can-Zhao <volcanofly@gmail.com>
@Can-Zhao
readme
2e5d1de 
Signed-off-by: Can-Zhao <volcanofly@gmail.com>
@Can-Zhao
readme
eb3ccd8 
Signed-off-by: Can-Zhao <volcanofly@gmail.com>
@KumoLiu KumoLiu requested review from ericspod and Nic-Ma November 22, 2024 11:27
@KumoLiu KumoLiu merged commit 7619862 into Project-MONAI:main Nov 24, 2024
6 checks passed
@Can-Zhao Can-Zhao deleted the maisi_readme branch November 25, 2024 00:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@KumoLiu KumoLiu KumoLiu approved these changes

@guopengf guopengf Awaiting requested review from guopengf

@dongyang0122 dongyang0122 Awaiting requested review from dongyang0122

@ericspod ericspod Awaiting requested review from ericspod

@Nic-Ma Nic-Ma Awaiting requested review from Nic-Ma

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Can-Zhao @KumoLiu