Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add maisi mask aug example #1748

Merged
merged 11 commits into from
Jul 4, 2024

Conversation

guopengf
Copy link
Contributor

@guopengf guopengf commented Jul 2, 2024

Fixes # .

Description

Add notebook example for tumor mask augmentation.

Checks

  • Avoid including large-size files in the PR.
  • Clean up long text outputs from code cells in the notebook.
  • For security purposes, please check the contents and remove any sensitive info such as user names and private key.
  • Ensure (1) hyperlinks and markdown anchors are working (2) use relative paths for tutorial repo files (3) put figure and graphs in the ./figure folder
  • Notebook runs automatically ./runner.sh -t <path to .ipynb file>

guopengf added 2 commits July 2, 2024 00:16
Signed-off-by: Pengfei Guo <pengfeig@nvidia.com>
Signed-off-by: Pengfei Guo <pengfeig@nvidia.com>
@guopengf guopengf self-assigned this Jul 2, 2024
Copy link

Check out this pull request on  ReviewNB

See visual diffs & provide feedback on Jupyter Notebooks.


Powered by ReviewNB

@guopengf
Copy link
Contributor Author

guopengf commented Jul 2, 2024

Hi @KumoLiu, I plan to add an example mask as tutorials/generative/maisi/data/example_mask.nii.gz. Where should I host this file? Shall I put it into https://github.com/Project-MONAI/MONAI-extra-test-data/releases/tag/0.8.1?

@KumoLiu
Copy link
Contributor

KumoLiu commented Jul 2, 2024

Hi @KumoLiu, I plan to add an example mask as tutorials/generative/maisi/data/example_mask.nii.gz. Where should I host this file? Shall I put it into https://github.com/Project-MONAI/MONAI-extra-test-data/releases/tag/0.8.1?

Yes, you can host it there.

Signed-off-by: Pengfei Guo <pengfeig@nvidia.com>
@guopengf guopengf marked this pull request as ready for review July 2, 2024 16:22
@guopengf guopengf requested a review from KumoLiu July 2, 2024 16:22
@guopengf
Copy link
Contributor Author

guopengf commented Jul 2, 2024

I think we have this error (https://github.com/Project-MONAI/tutorials/actions/runs/9764583292/job/26953264670?pr=1748) because some utility functions have not been merged. So I make it a draft PR first.

@guopengf guopengf marked this pull request as draft July 2, 2024 17:24
guopengf and others added 2 commits July 3, 2024 15:08
Signed-off-by: Pengfei Guo <pengfeig@nvidia.com>
@guopengf guopengf marked this pull request as ready for review July 3, 2024 15:10
@guopengf
Copy link
Contributor Author

guopengf commented Jul 3, 2024

This PR is ready for review once #1749 is merged.

Signed-off-by: Pengfei Guo <pengfeig@nvidia.com>
@KumoLiu
Copy link
Contributor

KumoLiu commented Jul 4, 2024

@guopengf seems premerge can not pass, did you run the notebook locally?

@guopengf
Copy link
Contributor Author

guopengf commented Jul 4, 2024

@guopengf seems premerge can not pass, did you run the notebook locally?

Yeah, I can successfully run it locally, as you can see those cell outputs. However, the augmentation functions rely on latest monai core dev branch. I don’t know if this causes problems.

@KumoLiu
Copy link
Contributor

KumoLiu commented Jul 4, 2024

Hi @guopengf,
Could you please add the file here https://github.com/Project-MONAI/tutorials/blob/main/runner.sh#L79 to exclude max_epochs check? Thanks.
https://github.com/Project-MONAI/tutorials/actions/runs/9788615557/job/27026970836?pr=1748#step:5:610

Signed-off-by: Pengfei Guo <pengfeig@nvidia.com>
@guopengf
Copy link
Contributor Author

guopengf commented Jul 4, 2024

Hi @guopengf, Could you please add the file here https://github.com/Project-MONAI/tutorials/blob/main/runner.sh#L79 to exclude max_epochs check? Thanks. https://github.com/Project-MONAI/tutorials/actions/runs/9788615557/job/27026970836?pr=1748#step:5:610

Hi @KumoLiu, thanks for the instruction! All tests are passed.

Copy link
Contributor

@KumoLiu KumoLiu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.
If you don't have other comments, I will merge this one. cc @Nic-Ma @mingxin-zheng

@KumoLiu KumoLiu merged commit 8857a5c into Project-MONAI:main Jul 4, 2024
6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants