Maisi readme #1743
Merged
Maisi readme #1743
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Can Zhao <canz@nvidia.com>
Signed-off-by: Can Zhao <canz@nvidia.com>
Signed-off-by: Can Zhao <canz@nvidia.com>
for more information, see https://pre-commit.ci
guopengf
reviewed
Jun 27, 2024
Signed-off-by: Can Zhao <canz@nvidia.com>
…into maisi_readme
KumoLiu
reviewed
Jun 28, 2024
Signed-off-by: Can Zhao <canz@nvidia.com>
Signed-off-by: Can Zhao <canz@nvidia.com>
for more information, see https://pre-commit.ci
Signed-off-by: Pengfei Guo <pengfeig@nvidia.com>
for more information, see https://pre-commit.ci
Signed-off-by: Pengfei Guo <pengfeig@nvidia.com>
for more information, see https://pre-commit.ci
KumoLiu
reviewed
Jul 29, 2024
|
Hi @Can-Zhao, please help renamed the generative dir to generation and modify the related "Setup environment" section. Thanks! |
I will change it after all other comments are resolved. Or we can open another PR to do it to make it more tractable |
Signed-off-by: Pengfei Guo <pengfeig@nvidia.com>
for more information, see https://pre-commit.ci
KumoLiu
approved these changes
Aug 1, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes # .
Description
Maisi readme.
Checks
./figurefolder./runner.sh -t <path to .ipynb file>