Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

auto fixes from pre-commit.com hooks #1198

Merged
merged 2 commits into from
Jan 30, 2023
Merged

auto fixes from pre-commit.com hooks #1198

merged 2 commits into from
Jan 30, 2023

Conversation

monai-bot
Copy link
Contributor

@monai-bot monai-bot commented Jan 30, 2023

Checks

  • Avoid including large-size files in the PR.
  • Clean up long text outputs from code cells in the notebook.
  • For security purposes, please check the contents and remove any sensitive info such as user names and private key.
  • Ensure (1) hyperlinks and markdown anchors are working (2) use relative paths for tutorial repo files (3) put figure and graphs in the ./figure folder
  • Notebook runs automatically ./runner.sh -t <path to .ipynb file>

@review-notebook-app
Copy link

Check out this pull request on  ReviewNB

See visual diffs & provide feedback on Jupyter Notebooks.


Powered by ReviewNB

Signed-off-by: Wenqi Li <wenqil@nvidia.com>
@wyli wyli requested review from mingxin-zheng and Nic-Ma January 30, 2023 09:40
@wyli
Copy link
Contributor

wyli commented Jan 30, 2023

after merging this PR I'll tag the main branch as 1.1 @mingxin-zheng @Nic-Ma

Copy link
Contributor

@wyli wyli left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

the tests are running out of the instance time limit 6hours... since these are probably non-breaking coding style changes, I'll merge and test on blossom cc @mingxin-zheng @Nic-Ma

@wyli wyli merged commit fc26020 into main Jan 30, 2023
@wyli wyli deleted the formatter branch January 30, 2023 14:11
boneseva pushed a commit to boneseva/MONAI-tutorials that referenced this pull request Apr 21, 2024
### Checks
<!--- Put an `x` in all the boxes that apply, and remove the not
applicable items -->
- [x] Avoid including large-size files in the PR.
- [x] Clean up long text outputs from code cells in the notebook.
- [x] For security purposes, please check the contents and remove any
sensitive info such as user names and private key.
- [x] Ensure (1) hyperlinks and markdown anchors are working (2) use
relative paths for tutorial repo files (3) put figure and graphs in the
`./figure` folder
- [ ] Notebook runs automatically `./runner.sh -t <path to .ipynb file>`

---------
Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants