Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

3752 revert workaround of fixing pip version #3778

Merged
merged 1 commit into from
Feb 8, 2022
Merged

3752 revert workaround of fixing pip version #3778

merged 1 commit into from
Feb 8, 2022

Conversation

wyli
Copy link
Contributor

@wyli wyli commented Feb 8, 2022 •
edited
Loading

Signed-off-by: Wenqi Li wenqil@nvidia.com

Fixes #3752

Description

will update blossom tests for the same once this is tested and merged.

Status

Ready

Types of changes

  • Non-breaking change (fix or new feature that would not break existing functionality).
  • Breaking change (fix or new feature that would cause existing functionality to change).
  • New tests added to cover the changes.
  • Integration tests passed locally by running ./runtests.sh -f -u --net --coverage.
  • Quick tests passed locally by running ./runtests.sh --quick --unittests --disttests.
  • In-line docstrings updated.
  • Documentation updated, tested make html command in the docs/ folder.

@wyli wyli changed the title revert workaround of fixing pip version 3752 revert workaround of fixing pip version Feb 8, 2022
@wyli
revert workaround
114b659 
Signed-off-by: Wenqi Li <wenqil@nvidia.com>
@wyli wyli force-pushed the 3752-revert-workaround branch from 28c020a to 114b659 Compare February 8, 2022 09:29
@wyli wyli requested review from Nic-Ma, pritishnahar95, rijobro and ericspod and removed request for pritishnahar95 February 8, 2022 10:03
@Nic-Ma Nic-Ma requested a review from IsaacYangSLA February 8, 2022 10:07
@wyli
Copy link
Contributor Author

wyli commented Feb 8, 2022

/build

@wyli wyli enabled auto-merge (squash) February 8, 2022 10:09
@wyli wyli merged commit 3c96cb8 into Project-MONAI:dev Feb 8, 2022
@wyli wyli deleted the 3752-revert-workaround branch April 27, 2022 22:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Nic-Ma Nic-Ma Nic-Ma approved these changes

@rijobro rijobro Awaiting requested review from rijobro

@ericspod ericspod Awaiting requested review from ericspod

@IsaacYangSLA IsaacYangSLA Awaiting requested review from IsaacYangSLA

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

pip install error since 22.0
2 participants
@wyli @Nic-Ma