-
-
Notifications
You must be signed in to change notification settings - Fork 62
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
PHEx Mv3 (WE DID IT BOYS) #53
Conversation
this is big |
This took me 3 collective hours of research, coding, and getting the fucking thing to work. And yes, I signed the CRX.
MV3 - At least we can block Prodigy's code! This took me 3 collective hours of research, coding, and getting the fucking thing to work. And yes, I signed the CRX. |
Remotely hosted code is no longer allowed; an extension can only execute JavaScript that is included within its package. I'm pretty sure that the migration guide said that we can still use |
Created a tracking issue. Also, updated to base branch. |
I'm going to figure out some way to load the game.min.js file from PHEx so we don't have to deal with P-NP or any derivative. This would probably break Infinite Zero, though. |
@Erisfiregamer1 I was confused when using ProdigyX's method of document events... kinda made me to decide "fuck this, i won't bother". |
bet I turned off code quality checking which should stop unused variables from being reported, but generic errors will still be reported. |
k |
Signed-off-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
This would be a legit error, except it's an extension, so no. Anyway that one I'll find a way to circumvent |
Signed-off-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
Signed-off-by: gemsvidø <gemsvido@gmail.com>
Signed-off-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
Signed-off-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
Test it yourselves, BUT FUCK YEEEAHHHH IT WORKS!!!! |
Let me test it. WAIT FOR MY REVIEW. |
BET |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Oh. My. God.
After all these months, after ALL THE FUCKING SUFFERING, after hosted's help... we've done it. MV3 is functioning.
Special thanks to:
- hostedposted, for helping us a lot
- Svido for finally getting it to work and also doing their best to finish it
- Everyone else who contributed.
I refuse to wait. LGTM
FUCK YEAH!!!!!! |
WOOOOo |
I'll start signing, releasing, etc. |
You do that- I'll ensure that the P-NP servers on my network stay updated if need be. |
BET BROTHER |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Why didn't I think of this? (commit: THIS WORKED ONG)
xd |
COMPLETE on August 7, 2022.
Once CSP removal is done then add the redirect for**Alternative found/load-game.min.js
./.github/workflows/removeonmerge.yml
.Does this look good?
- [ ] @donaldli2020Skipped via executive decision by Alpha (Eris).Releasing
First we wait until the Alphas have checked the boxes.