Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Error in the background page #78

Closed
Manvel opened this issue Dec 16, 2019 · 2 comments
Closed

Error in the background page #78

Manvel opened this issue Dec 16, 2019 · 2 comments
Assignees
Milestone

Comments

@Manvel
Copy link
Member

Manvel commented Dec 16, 2019

Uncaught (in promise) TypeError: Error in invocation of browsingData.remove(browsingData.RemovalOptions options, browsingData.DataTypeSet dataToRemove, optional function callback): Error at parameter 'dataToRemove': Unexpected property: 'removeAll'.
    at browser-polyfill.min.js:1
    at new Promise (<anonymous>)
    at Proxy.<anonymous> (browser-polyfill.min.js:1)
    at Object.apply (browser-polyfill.min.js:1)
    at deleteBrowsingData (back.js:313)
    at profileStart (back.js:262)
@Manvel Manvel added this to the release-next milestone Dec 16, 2019
@Manvel Manvel self-assigned this Dec 16, 2019
@Manvel
Copy link
Member Author

Manvel commented Dec 19, 2019

Not able to reproduce this anymore.

@Manvel Manvel closed this as completed Dec 19, 2019
@Manvel
Copy link
Member Author

Manvel commented Dec 19, 2019

Was able to reproduce, after reinstalling the extension. Seems like the issue was because we were not removing removeAll from browsingData object at initialization.

@Manvel Manvel reopened this Dec 19, 2019
Manvel added a commit that referenced this issue Dec 19, 2019
@Manvel Manvel closed this as completed Dec 19, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant