Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update IDialogResult and DialogResult #2761

Merged
merged 3 commits into from
Aug 27, 2022
Merged

Update IDialogResult and DialogResult #2761

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
0cc89bd
Update IDialogResult and DialogResult
niimima Aug 25, 2022
6ca04fd
Update IDialogResult and DialogResult comments
niimima Aug 26, 2022
8783540
Remove a extra "returns" word.
niimima Aug 27, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
11 changes: 3 additions & 8 deletions src/Forms/Prism.Forms/Services/Dialogs/DialogResult.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -6,19 +6,14 @@
namespace Prism.Services.Dialogs
{
/// <summary>
/// An <see cref="IDialogResult"/> that contains <see cref="IDialogParameters"/> from the dialog
/// and the <see cref="System.Exception"/> of the dialog.
/// Provides returns information about a dialog that has been closed.
Copy link
Member

@brianlagunas brianlagunas Aug 26, 2022 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks like a copy/paste issue. Please remove the extra "returns" word.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sorry, I remove this word.
https://github.com/PrismLibrary/Prism/pull/2761/files#diff-0d0a9b1f968cdc60f0420e45398c06795f2b4d473269f729f6a2f977c96ac071R9

/// </summary>
internal class DialogResult : IDialogResult
{
/// <summary>
/// The exception of the dialog.
/// </summary>
/// <inheritdoc />
public Exception Exception { get; set; }

/// <summary>
/// The parameters from the dialog.
/// </summary>
/// <inheritdoc />
public IDialogParameters Parameters { get; set; }
}
}
7 changes: 3 additions & 4 deletions src/Forms/Prism.Forms/Services/Dialogs/IDialogResult.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3,18 +3,17 @@
namespace Prism.Services.Dialogs
{
/// <summary>
/// Contains <see cref="IDialogParameters"/> from the dialog
/// and the <see cref="System.Exception"/> of the dialog.
/// Represents a class that returns information about a dialog that has been closed.
/// </summary>
public interface IDialogResult
{
/// <summary>
/// The exception of the dialog.
/// Gets the exception of the dialog.
/// </summary>
Exception Exception { get; }

/// <summary>
/// The parameters from the dialog.
/// Gets the parameters from the dialog.
/// </summary>
IDialogParameters Parameters { get; }
}
Expand Down