bqn: Add bqn language support. #3515
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
JS File Size Changes (gzipped)A total of 2 files have changed, with a combined diff of +720 B (+26.7%).
|
RunDevelopment
requested changes
Aug 5, 2022
There was a problem hiding this comment.
Thank you for the PR @yewscion!
The code itself looks good, but please fix the formatting. We use ESLint to do that, so either install an ESLint plugin/extension for your editor or run npm run lint:fix (this command won't work until the Unicode regex is fixed, see my last comment below).
|
Coverage tests fail because the |
+ Added Punctuation Test. + Added token test for 𝕣, _𝕣, and _𝕣_ 'special-name' tokens. ~ 'comment' token is now greedy. ~ 'shebang' token is now greedy and doesn't use '\s'. ~ Fixed Punctuation Regexp. ~ Formatted using `npm run lint:fix`. - Removed '/u' modifier flag from all patterns aside from 'special-name'.
dzaima
reviewed
Aug 5, 2022
RunDevelopment
requested changes
Aug 5, 2022
RunDevelopment
approved these changes
Aug 5, 2022
|
Thank you for contributing @yewscion! |
|
Thank You @RunDevelopment! Sorry there were so many issues to fix; I will try to be more attentive in the future. |
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related to: #3514
This patch adds support for the BQN language to PrismJS, following the instructions in the documentation. Let me know if anything needs fixed before merge.