fix: better tag selection

[Chunjee]

No description provided.

[github-actions]

No JS Changes

Generated by 🚫 dangerJS against 522c9d3

[RunDevelopment]

@Chunjee Could you please explain what issue you are trying to fix and how your fix works?

[Chunjee]

Incorrect tag selection (first red box):

Post fix:

[RunDevelopment]

I see, in that case, your fix is not correct. Try this example.

I have a question: are labels line-based? So can there be any no-space, no-comments after the label on the same line?

If they are, then your problem can be fixed like this:

@@ -11,8 +11,13 @@ Prism.languages.autohotkey = {
                }
        ],
+       'tag': {
+               // labels
+               pattern: /^([ \t]*)[^\s,`":]+(?=:[ \t]*$)/m,
+               lookbehind: true
+       },
        'string': /"(?:[^"\n\r]|"")*"/m,
-       'tag': /^[ \t]*[^\s:]+?(?=:(?:[^:]|$))/m, //labels
        'variable': /%\w+%/,
        'number': /\b0x[\dA-Fa-f]+\b|(?:\b\d+(?:\.\d*)?|\B\.\d+)(?:[Ee]-?\d+)?/,

[Chunjee]

I am afraid that comments are allowed after a label; and in some unique circumstances, before.

After:

validLabel: ; a comment

Before:

/* multiline comment
*/ validLabel:

[RunDevelopment]

comments are allowed after a label; and in some unique circumstances, before.

Perfect. In that case, you can use the code I commented above.

[Chunjee]

Using the code in the comments appears to have a similar issue:

[RunDevelopment]

No, it doesn't.

You probably forgot to remove the old tag (see diff above).

[Chunjee]

Thank you, after some more experimentation I think the issue was a duplicate string definition.