New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

updated to accept NAN values in string columns: Fix for issue #138 #185

Open

kgovind0001 wants to merge 1 commit into PriorLabs:main from kgovind0001:issue#138

kgovind0001 commented Feb 14, 2025

@noahho Thank you very much for the feedback and guidance. This request should fix the issue138 . I have made following corrections.

Added the placement for NaN in string columns. Since the same processing needed to be applied in prediction, I had to add an attribute placeholder to the class.
I have made similar changes to the regression also.
3 tests have failed related to attribute. Please let me know if there is anything you would like to have another look.

Thank you.


          updated to accept NAN values in string columns

ff574f2

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet