Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix local notification not being shown on android #994

Merged
merged 2 commits into from
Feb 10, 2025

Conversation

DavidDWiser
Copy link
Member

Overview

Closes: #925

This PR fixes a bug where local notifications weren't displayed on an android device. It also conditionally displays the notification based on user settings controlled from the profile page.

Checklist

Implementation

  • Implementation matches ticket acceptance criteria and technical notes
  • Manually tested against Acceptance Criteria
    - [ ] UI checked in Light / Dark mode

Stability

  • Checked if changes affect any features and verified affected features work as expected
    - [ ] Added unit tests for new code and verified existing tests work as expected

Code quality
- [ ] Updated CHANGELOG.md, README.md and package versions in pubspec.yaml
- [ ] Dependencies are updated to latest versions or new tickets are created if there are breaking changes or deprecations
- [ ] If an unrelated part of the codebase needs to be updated or refactored, create tickets with proposed changes

Copy link

codecov bot commented Feb 5, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 95.66%. Comparing base (5ff0364) to head (20147e2).
Report is 3 commits behind head on develop.

Additional details and impacted files
@@           Coverage Diff            @@
##           develop     #994   +/-   ##
========================================
  Coverage    95.66%   95.66%           
========================================
  Files          121      121           
  Lines         2632     2632           
========================================
  Hits          2518     2518           
  Misses         114      114           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@DavidDWiser DavidDWiser merged commit dadb2ba into develop Feb 10, 2025
18 checks passed
@DavidDWiser DavidDWiser deleted the feat/925-android-notifications-not-working branch February 10, 2025 15:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Notifications in rx_bloc_cli project not working on Android
2 participants