Logout button improvements - Fix padding on loading. Hide the button … #977
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…after logout. Optimise the business logic
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## develop #977 +/- ##
========================================
Coverage 95.66% 95.66%
========================================
Files 121 121
Lines 2632 2632
========================================
Hits 2518 2518
Misses 114 114 ☔ View full report in Codecov by Sentry. |
StanevPrime
requested changes
Jan 16, 2025
There was a problem hiding this comment.
Do we really need to move the logout button ?
There was a problem hiding this comment.
It was an issue in the mocking one of states. I have fixed it and reupload tests.
JvnSlv
approved these changes
Jan 17, 2025
GoranPrime
requested changes
Jan 23, 2025
...plates/bricks/lib_auth/__brick__/lib/feature_profile/ui_components/logout_action_button.dart
Outdated
Show resolved
Hide resolved
GoranPrime
approved these changes
Jan 23, 2025
StanevPrime
requested changes
Jan 27, 2025
| ), | ||
| child: RxBlocMultiBuilder2<UserAccountBlocType, bool, bool>( | ||
| state1: (bloc) => bloc.states.isLoading, | ||
| state2: (bloc) => bloc.states.loggedIn, |
There was a problem hiding this comment.
Let's try to immediately redirect the user to the login page, instead of hiding the button
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
…after logout. Optimise the business logic
Overview
< Pull Request Description >
Checklist
Implementation
Stability