Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feat/update rx bloc cli project creation #644

Merged
merged 13 commits into from
Feb 9, 2024

Conversation

DavidDWiser
Copy link
Member

Overview

Closes: #637

This PR removes the android and ios directories from mason templates, which are generated by the flutter create command. Instead of manually creating flavors, they are now generated using the flutter_flavorizr package with auto-generated configs on top of the existing codebase.

Checklist

Implementation

  • Implementation matches ticket acceptance criteria and technical notes
  • Manually tested against Acceptance Criteria

Stability

  • Checked if changes affect any features and verified affected features work as expected

Code quality

  • Updated CHANGELOG.md, README.md and package versions in pubspec.yaml
  • Dependencies are updated to latest versions or new tickets are created if there are breaking changes or deprecations
  • If an unrelated part of the codebase needs to be updated or refactored, create tickets with proposed changes

@StanevPrime
Copy link
Member

image

I need to run the build runner by hand. Please make this automatic

@codecov-commenter
Copy link

codecov-commenter commented Feb 7, 2024

Codecov Report

Attention: 1 lines in your changes are missing coverage. Please review.

Comparison is base (953f1b6) 85.70% compared to head (7156c18) 85.66%.

Files Patch % Lines
...bloc_cli/lib/src/extensions/string_extensions.dart 0.00% 1 Missing ⚠️

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files
@@             Coverage Diff             @@
##           develop     #644      +/-   ##
===========================================
- Coverage    85.70%   85.66%   -0.05%     
===========================================
  Files           98       98              
  Lines         2141     2142       +1     
===========================================
  Hits          1835     1835              
- Misses         306      307       +1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@DavidDWiser
Copy link
Member Author

DavidDWiser commented Feb 7, 2024

image I need to run the build runner by hand. Please make this automatic

The generation process does execute the build runner during the post generation steps. The project from the screenshot is the test project or did you use the rx_bloc_cli to externally generate a project? Also, did you wait for the whole generation process to be complete before opening the project? @StanevPrime

@StanevPrime
Copy link
Member

StanevPrime commented Feb 7, 2024

image image

@DDavidPrime, please have a look at the errors above. I believe you can simply solve this by uncomment this line in the Podfile in the process procedure

image

Be aware that after that the pod install completes successfully but then the following error appears

image

@DavidDWiser DavidDWiser merged commit 4c284f3 into develop Feb 9, 2024
30 checks passed
@DavidDWiser DavidDWiser deleted the feat/update_rx_bloc_cli_project_creation branch February 9, 2024 08:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Implement a solution that keeps the native part of the generated Flutter app up-to-date
4 participants