fix: Better initialization of NEX server accounts #29
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Initializing the server accounts in their own thread (e.g. the authentication and secure servers) can cause a race condition where the secure account hasn't been set up yet when authentication configures `ticket-granting`, causing sometimes crashes on startup. This has happened on production causing unnecesary restarts. To fix this, initialize the accounts on the `init` function to ensure they will always be accessible when needed.
|
Looks good to me. This should become the standard |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves #XXX
Changes:
Initializing the server accounts in their own thread (e.g. the authentication and secure servers) can cause a race condition where the secure account hasn't been set up yet when authentication configures
ticket-granting, causing sometimes crashes on startup.This has happened on production causing unnecesary restarts. To fix this, initialize the accounts on the
initfunction to ensure they will always be accessible when needed.