Update PHPStan in project

README.md

@@ -46,7 +46,7 @@ Install dependencies with composer. Two CI tools are configured for this project
 ```
 composer install
 php vendor/bin/php-cs-fixer fix --no-interaction --dry-run --diff
-php phpstan analyse tests/phpstan/phpstan.neon
+php vendor/bin/phpstan analyse --configuration=tests/phpstan/phpstan.neon
 ```
 
 Before submitting changes to the projects, tests can be run with:

bin/header-stamp

@@ -45,5 +45,6 @@ $command = new UpdateLicensesCommand();
 
 $application->add($command);
 
+// @phpstan-ignore argument.type (Name is set in the command)
 $application->setDefaultCommand($command->getName());
 $application->run();

composer.json

@@ -34,6 +34,6 @@
     "author": "PrestaShop",
     "require-dev": {
         "prestashop/php-dev-tools": "1.*",
-        "phpstan/phpstan": "^0.12.83"
+        "phpstan/phpstan": "^1.12"
     }
 }

src/Command/UpdateLicensesCommand.php

@@ -446,10 +446,6 @@ private function addLicenseToJsonFile(SplFileInfo $file): void
         $this->reportOperationResult($encodedContent, $file->getContents(), $file->getFilename());
     }
 
-    /**
-     * @var string
-     * @var string
-     */
     private function reportOperationResult(string $newFileContent, string $oldFileContent, string $filename): void
     {
         if ($newFileContent !== $oldFileContent) {

src/LicenseHeader.php

@@ -22,6 +22,8 @@
 
 namespace PrestaShop\HeaderStamp;
 
+use Exception;
+
 /**
  * Class responsible of loading license file in memory and returning its content
  */
@@ -52,7 +54,7 @@ public function __construct(string $filePath)
     public function getContent(): string
     {
         if (null === $this->content) {
-            $this->loadFile();
+            $this->content = $this->loadFile();
         }
 
         return $this->content;
@@ -61,7 +63,7 @@ public function getContent(): string
     /**
      * Checks the file and loads its content in memory
      */
-    private function loadFile(): void
+    private function loadFile(): string
     {
         if (!\file_exists($this->filePath)) {
             // If the file is not found, we might have a relative path
@@ -84,9 +86,9 @@ private function loadFile(): void
 
         $content = \file_get_contents($this->filePath);
         if ($content === false) {
-            return;
+            throw new Exception('Cannot load license file ' . $this->filePath . '.');
         }
 
-        $this->content = $content;
+        return $content;
     }
 }

tests/phpstan/phpstan.neon

@@ -1,7 +1,7 @@
 parameters:
   paths:
-    - ../../src/
+    - ../../src
     - ../../bin/header-stamp
-  level: 7
+  level: 8
   inferPrivatePropertyTypeFromConstructor: true
   ignoreErrors: