Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix dependency installation for flow submission #17289

Merged
merged 2 commits into from
Feb 26, 2025
Merged

Conversation

desertaxle
Copy link
Member

I was running into issues with the @kubernetes decorator because prefect-kubernetes wasn't available during unpickling. Turns out subprocess.check_call won't propagate the current environment variables for you, so the dependencies scooped up using uv pip freeze were being installed in the wrong virtual environment. This PR fixes that and I've verified the fix by running it against this branch.

Copy link

codspeed-hq bot commented Feb 26, 2025

CodSpeed Performance Report

Merging #17289 will not alter performance

Comparing fix-adhoc-deps (f087576) with main (6836cce)

Summary

✅ 2 untouched benchmarks

@desertaxle desertaxle merged commit 27db9ba into main Feb 26, 2025
49 checks passed
@desertaxle desertaxle deleted the fix-adhoc-deps branch February 26, 2025 16:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants