Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[UI v2] feat: Refines flow run card in replacement for flow run data table #17242

Merged
merged 1 commit into from
Feb 24, 2025
Merged

[UI v2] feat: Refines flow run card in replacement for flow run data table #17242

merged 1 commit into from
Feb 24, 2025

Conversation

devinvillarosa
Copy link
Contributor

@devinvillarosa devinvillarosa commented Feb 21, 2025 •
edited
Loading

Refines flow run card in replacement for flow run data table

  1. Removes flow run data table components in favor for the card UX
  2. Updates and refines flow run card component

Upcoming PR, will update the hook to join deployment data to the flow run

Screen.Recording.2025-02-21.at.1.49.19.PM.mov
Screen.Recording.2025-02-21.at.1.44.15.PM.mov

Checklist

  • This pull request references any related issue by including "closes <link to issue>"
    • If no issue exists and your change is not a small fix, please create an issue first.
  • If this pull request adds new functionality, it includes unit tests that cover the changes
  • If this pull request removes docs files, it includes redirect settings in mint.json.
  • If this pull request adds functions or classes, it includes helpful docstrings.

Relates to #15512

@github-actions github-actions bot added the ui-replatform Related to the React UI rewrite label Feb 21, 2025
devinvillarosa
devinvillarosa commented Feb 21, 2025
View reviewed changes
ui-v2/src/components/ui/typography/styles.ts Outdated
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

adding support for text-xs sizing

@devinvillarosa devinvillarosa marked this pull request as ready for review February 21, 2025 21:51
@devinvillarosa devinvillarosa marked this pull request as draft February 21, 2025 22:04
@devinvillarosa devinvillarosa marked this pull request as ready for review February 21, 2025 22:15
@devinvillarosa devinvillarosa force-pushed the refine-flow-runs-card branch 7 times, most recently from 6aadcb7 to a069c76 Compare February 24, 2025 18:57
pleek91
pleek91 approved these changes Feb 24, 2025
View reviewed changes
Copy link
Contributor

@pleek91 pleek91 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

ui-v2/src/components/flow-runs/flow-run-card/card-properties/flow-run-name.tsx
</BreadcrumbLink>
</BreadcrumbItem>
)}
{flow && <BreadcrumbSeparator>/</BreadcrumbSeparator>}
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Its nice if these sort of separators just hide themselves if they're the :first-child or :last-child or .separator + .separator. Not related to this PR, but how do you feel about that?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

great suggestion. Let me add it to this PR

@devinvillarosa devinvillarosa force-pushed the refine-flow-runs-card branch 2 times, most recently from c5b72fb to dd4df23 Compare February 24, 2025 22:53
@devinvillarosa devinvillarosa merged commit ab2634c into main Feb 24, 2025
8 checks passed
@devinvillarosa devinvillarosa deleted the refine-flow-runs-card branch February 24, 2025 23:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@pleek91 pleek91 pleek91 approved these changes

@aaazzam aaazzam Awaiting requested review from aaazzam aaazzam is a code owner

@desertaxle desertaxle Awaiting requested review from desertaxle desertaxle is a code owner

@devangrose devangrose Awaiting requested review from devangrose

Assignees
No one assigned
Labels
ui-replatform Related to the React UI rewrite
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@devinvillarosa @pleek91